From 462669dfa1c38bc981228e606e4c9013cbb790f1 Mon Sep 17 00:00:00 2001
From: laentropia <aadrian887mh@gmail.com>
Date: Fri, 17 Apr 2026 07:47:02 -0600
Subject: [PATCH] test: added test for push front

---
 src/arraylist.c       |   4 +-
 test/test_arraylist.c | 108 ++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 110 insertions(+), 2 deletions(-)

diff --git a/src/arraylist.c b/src/arraylist.c
index a362266..6e822f3 100644
--- a/src/arraylist.c
+++ b/src/arraylist.c
@@ -260,9 +260,9 @@ ArrayListErr arraylist_pop_front(ArrayList *arr, void *out) {
     }
 
     memmove(
-        arr->buffer + arr->elem_size,
         arr->buffer,
-        (arr->len - 1) * arr->elem_size);
+        arr->buffer + arr->elem_size,
+        arr->len * arr->elem_size);
 
     arr->len--;
 
diff --git a/test/test_arraylist.c b/test/test_arraylist.c
index c0c561a..270a48e 100644
--- a/test/test_arraylist.c
+++ b/test/test_arraylist.c
@@ -504,6 +504,104 @@ static void test_pop_back_null_out(void **state) {
     arraylist_destroy(&arr);
 }
 
+// Pop front
+static void test_pop_front_single_element(void **state) {
+    (void) state;
+
+    ArrayList *arr = arraylist_init(64, sizeof(int));
+    assert_non_null(arr);
+
+    for (int i = 0; i < 10; i++) {
+        assert_uint_equal(arraylist_push_back(arr, &i), ARRLIST_OK);
+    }
+
+    int m;
+    assert_uint_equal(arraylist_pop_front(arr, &m), ARRLIST_OK);
+    assert_uint_equal(m, 0);
+
+    arraylist_destroy(&arr);
+}
+
+static void test_pop_front_multiple_elements(void **state) {
+    (void) state;
+
+    ArrayList *arr = arraylist_init(64, sizeof(int));
+    assert_non_null(arr);
+
+    for (int i = 0; i < 10; i++) {
+        assert_uint_equal(arraylist_push_back(arr, &i), ARRLIST_OK);
+    }
+
+    int m;
+    size_t size = arraylist_size(arr);
+    for (int i = 0; i < 6; i++) {
+        assert_uint_equal(arraylist_pop_front(arr, &m), ARRLIST_OK);
+        assert_uint_equal(arraylist_size(arr), size - (i + 1));
+        assert_uint_equal(m, i);
+    }
+
+    arraylist_destroy(&arr);
+}
+
+static void test_pop_front_until_empty(void **state) {
+    (void) state;
+
+    ArrayList *arr = arraylist_init(64, sizeof(int));
+    assert_non_null(arr);
+
+    for (int i = 0; i < 10; i++) {
+        assert_uint_equal(arraylist_push_back(arr, &i), ARRLIST_OK);
+    }
+
+    int m;
+    size_t size = arraylist_size(arr);
+    for (int i = 0; i < 10; i++) {
+        assert_uint_equal(arraylist_pop_front(arr, &m), ARRLIST_OK);
+        assert_uint_equal(arraylist_size(arr), size - (i + 1));
+        assert_uint_equal(m, i);
+    }
+
+    assert_uint_equal(arraylist_pop_front(arr, &m), ARRLIST_EMPTY);
+
+    arraylist_destroy(&arr);
+}
+
+static void test_pop_front_empty_array(void **state) {
+    (void) state;
+
+    ArrayList *arr = arraylist_init(64, sizeof(int));
+    assert_non_null(arr);
+
+    int n;
+    assert_uint_equal(arraylist_pop_front(arr, &n), ARRLIST_EMPTY);
+
+    arraylist_destroy(&arr);
+}
+
+static void test_pop_front_null_array(void **state) {
+    (void) state;
+
+    ArrayList *arr = NULL;
+
+    int n;
+    assert_uint_equal(arraylist_pop_front(arr, &n), ARRLIST_NULL_ARG);
+}
+
+static void test_pop_front_null_out(void **state) {
+    (void) state;
+
+    ArrayList *arr = arraylist_init(64, sizeof(int));
+    assert_non_null(arr);
+
+    int n = 8;
+    assert_uint_equal(arraylist_push_back(arr, &n), ARRLIST_OK);
+
+    assert_uint_equal(arraylist_pop_front(arr, NULL), ARRLIST_OK);
+
+    arraylist_destroy(&arr);
+}
+
+
 int main(void) {
     const struct CMUnitTest init[] = {
         cmocka_unit_test(test_init_valid_parameters),
@@ -559,6 +657,15 @@ int main(void) {
         cmocka_unit_test(test_pop_back_null_out),
     };
 
+    const struct CMUnitTest pop_front[] = {
+        cmocka_unit_test(test_pop_front_single_element),
+        cmocka_unit_test(test_pop_front_multiple_elements),
+        cmocka_unit_test(test_pop_front_until_empty),
+        cmocka_unit_test(test_pop_front_empty_array),
+        cmocka_unit_test(test_pop_front_null_array),
+        cmocka_unit_test(test_pop_front_null_out),
+    };
+
     int rc = 0;
 
     rc += cmocka_run_group_tests(init, NULL, NULL);
@@ -568,6 +675,7 @@ int main(void) {
     rc += cmocka_run_group_tests(push_front, NULL, NULL);
     rc += cmocka_run_group_tests(insert, NULL, NULL);
     rc += cmocka_run_group_tests(pop_back, NULL, NULL);
+    rc += cmocka_run_group_tests(pop_front, NULL, NULL);
 
     return rc;
 }