laentropia/Rusty-Matrices
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Modified get_determinant eliminating unnecesary loop that went exchanging the columns of the matrix

Browse Source
This commit is contained in:
Alonso Adrian Martinez Hernandez
2025-10-29 22:34:50 -06:00
parent b8005a5a97
commit cc909f9b52
1 changed files with 10 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
src/lib.rs
View File

@@ -192,17 +192,6 @@ impl<
} }
x += 1; x += 1;
} }
// Restart x for exchanging columns if necessary
x = i + 1;
while pivot.is_zero() && x < self.columns {
if !trig_matrix.get(i, x).is_zero() {
trig_matrix.exchange_columns(i, x);
sign = -sign;
pivot = *trig_matrix.get(i, i);
break;
}
x += 1;
}
// If even exchanging in all ways posible pivot is still 0 // If even exchanging in all ways posible pivot is still 0
// then determinant is 0 // then determinant is 0
if pivot.is_zero() { if pivot.is_zero() {
@@ -764,6 +753,16 @@ mod tests {
#[test] #[test]
fn get_determinant_4() { fn get_determinant_4() {
let mut matrix = Matrix::new(3, 3, 0.0); let mut matrix = Matrix::new(3, 3, 0.0);
matrix.set(0, 0, 2.0);
matrix.set(1, 0, 0.0);
matrix.set(2, 0, 1.0);
matrix.set(0, 1, 3.0);
matrix.set(1, 1, 4.0);
matrix.set(2, 1, 0.0);
matrix.set(0, 2, 5.0);
matrix.set(1, 2, 1.0);
matrix.set(2, 2, 6.0);
assert_eq!(matrix.get_determinant(), 31.0);
} }
} }